Guillaume Petiot

The future I envision for this option is to have: - `break-collection-expressions = wrap-or-vertical` that would replace `wrap` and `fit-or-vertical`, and wrap by default unless one element becomes too complex,...

First here are some examples to compare the 4 behaviors: `wrap`: ```ocaml let _ = [ aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; ] let _ = [ aaa_bbb_ccc_ddd; aaa_bbb_ccc_ddd; (fun...

We can rename the values like this: - `break-collection-expressions = wrap-or-vertical` --> `break-collection-expressions = auto` - `break-collection-expressions = vertical` --> `break-collection-expressions = always` Is there any objection to removing `fit-or-vertical`...

Here is the diff with the 3 profiles, collections wrapped by default unless the elements are "complex": ```diff diff --git a/testsuite/tests/lib-unix/common/cloexec.ml b/testsuite/tests/lib-unix/common/cloexec.ml index e1ec5431a..a082f591b 100644 --- a/testsuite/tests/lib-unix/common/cloexec.ml +++ b/testsuite/tests/lib-unix/common/cloexec.ml @@...

Maybe we could use a `--strict` option for ocamlformat that would treat all warnings as errors, not limited the the docstring warnings. Already discussed with @jberdine in #1388 although it...

I don't know what would look better in odoc's output, I'm neutral regarding using `wrap "[@;" "@ ]"` or `wrap "[@;" "@,]"`, but I admit having spaces added can be...

I would like to merge this one before releasing 0.20.0 so people can try it out before we deprecate the other values of this option.

I refreshed the PR. I think the new behavior is close to what you described but doesn't break if the expression doesn't reach the margin. Breaking systematically sounds a bit...

> But I think that it would still be better to put `sig` at the end of the preceding line rather than on its own line and increasing the indentation...

@CraigFe does that fix every case you encountered?