Guillaume Petiot

Results 109 comments of Guillaume Petiot

@vouillon I added some debug output in js_top_worker (https://github.com/jonludlam/js_top_worker/compare/main...gpetiot:js_top_worker:debug-toplevel) but it doesn't show up in the browser debug console. I also checked that there is no minify and that we...

No I didn't make any progress since my last comment. My team is deprioritizing this for the moment. I will keep trying to fix this on the side, if someone...

I cannot reproduce this bug with the `master` (2.3.0+) version of odoc (same dune version), do you still observe it after upgrading odoc?

Maybe I could reframe this question as: would it be possible to customize the dockerfiles generated by ocaml-ci, here is the kind of workflow I would like to have: https://github.com/tarides/okra/blob/main/.github/workflows/build.yml...

I noticed there is already a branch (`500`) doing that, but I cannot push on it. It's building locally with ocaml 5.0 though.

This code uses the default conf if no path is provided to run_format_with_args. If there is a path, then we check if there is an `.ocamlformat` if `enable-outside-detected-project = false`...

Out of curiosity is there some `.ocp-indent` file in the project that you don't want to get formatted? That would explain why the formatting is enabled and the default configuration...

I will have a look soon. I'm also interested in having the opinion of @emillon on this design (if you have the bandwidth ofc!), or someone else also having experience...

To give some context, ocamlformat never aimed at subsuming ocp-indent, nor be fully compatible. Because a few of ocp-indent settings don't make sense from ocamlformat's pov, I don't remember which...

I'm in favor of doing this in the ocaml parser directly. This would also make ocamlformat's job easier (assuming there is a flag to tell us whether there is a...