Guillaume Petiot

Results 109 comments of Guillaume Petiot

I had a look at this one, the issue is that the "easy fix" that would fix this one would introduce regressions in a lot of places because the comment...

Hi, sorry for the late reply. It's possible to achieve this behavior by setting: ``` wrap-fun-args = false ``` in your `.ocamlformat`. This is not the default behavior indeed (cc...

There was an attempt at supporting `ocp-indent` options in ocamlformat as you can see, but it's far from perfect, mostly due to the fact that as opposed to ocp-indent, we...

> Is there one "main style" that truly tries to get you most of your 80 columns ? No, but here is a short description of the styles: - the...

> What is the status of this? I'm stuck addressing Jules' comment, there are too many things to do to adapt odoc-parser to feed it a lexbuf (@Julow it expects...

I finally went with your first suggestion (parser taking a string instead of a lexbuf), let me know what you think!

I don't have a windows machine to confirm, but it looks like this comes from `tools/build-mingw64.sh`, are the tags missing, or `dune subst` shouldn't be executed? (cc @emillon)

I removed the `dune subst` action and re-uploaded the binaries for 0.21.0 and 0.20.1 (0.20.0 and 0.19.0 don't build), is the problem fixed? I don't have a working windows environment...

I reverted the commit and regenerated binaries, they should be identical as the first ones you tried. I also tried updating the `checkout` github action to use v3 (apparently there...

I am still not sure this is the best, but what we could do is to also enable for the formatting if we are in one of these cases, the...