Guillaume Petiot comments

Results 109 comments of


                                            Guillaume Petiot

Feature request: Allow submodule-body indentations other than 2 spaces

Hi, my personal opinion about this kind of options is that it was a mistake to add them in ocamlformat in the first place, as it adds noise in the...

Feature request: Allow submodule-body indentations other than 2 spaces

Sorry for the late update, my position didn't really change in the meantime, we still avoid adding new options, and so far most people seem happy with the current indentation...

Loop on `include` of shadowing module type substitution

I can't reproduce this issue either on 2.4.3 or on the master branch. What commands did you use exactly?

WIP: Backport 5.2 changes to parser-standard

This only impacts `parser-standard`, which `parser-extended` doesn't depend on. This will be good to go as soon as the tests are passing.

Consistent formatting of module types

Are there regressions blocking this PR? or just the merge? Because the output looks like a net improvement and I would really like to have it merged!

Break long string literal arguments

I agree the diff is a clear improvement to me. Should we ask the opinion of the community? @samoht ?

Improve the indentation of classes and class types

It wouldn't shock me to de-indent the `object` keyword, that's done for `struct` in some cases and it looks nice: ```ocaml module M (A : sig module type T end)...

Represent the expr sequence as a list

There is already a test of the facebook trace calls: `test/passing/tests/pre_post_extensions.ml`

Improve documentation on usage

Steps 4, 5 and 6 from this gist are just `dune-release`, so basically: - optional: integrate `dune-release lint` to your CI - `dune-release tag x.y.z` - `dune-release`