Jerry Berg comments

Results 85 comments of


                                            Jerry Berg

Register new extension in options.md

@johan-groenenboom do you wish to proceed?

Excessive new warning in Python protobuf runtime

Thank you for the feeback. We'll review at our next technical blockers meeting.

Excessive new warning in Python protobuf runtime

We'll fix this in the 29.x release.

JsonFormat - allow one-liners

@michaldo @midovlvn Be sure to sign the CLA so we can look at your PR when it is ready.

JsonFormat - allow one-liners

@michaldo I've tried to rerun the tests a couple of times. I suspect that you need to rebase and we can try again.

JsonFormat - allow one-liners

Oh shoot. @midovlvn it looks like you still haven't signed the CLA. We can't go any further until that happens.

JsonFormat - allow one-liners

@michaldo I'm so sorry to realize this late. I can't merge this change because it changes the return type of public methods. That isn't ABI compatible -- it qualifies as...

Add weakref tests for python messages + fix for upb implementation

Waiting on response from @bostikforever

protobuf::message using protobuf::map across dlls leads to crashes

@acozzette can you take a look at this?

protobuf::message using protobuf::map across dlls leads to crashes

In general, if you are building an application using DLLs and you plan to pass objects across DLL boundaries, the code that supports those objects also needs to be in...