Jerry Berg comments

Results 85 comments of


                                            Jerry Berg

Build requires C++14, CMake doesn't set it

@rgov Would you be willing to help out with a PR to fix this?

Build requires C++14, CMake doesn't set it

@ericsalo if @rgov provides a PR, can you review?

Better configurability for portability and robustness

@JCash Protobuf C++ only supports compilers and platforms as described here: https://opensource.google/documentation/policies/cplusplus-support If you are using a compiler on that list, please tell us which one and we will look...

Assigning to repeated field does not work

@anandolee Can you answer why assignment syntax doesn't work for repeated fields?

Message FieldNameEntry not allowed as map value type for field_name

The problem here is that protoc is generating a message named FooEntry for the map field foo and that conflicts with your user-defined message FooEntry. protoc is not adding the...

Message FieldNameEntry not allowed as map value type for field_name

@jhump my apologies for not carefully reading the initial example. You are entirely correct that the two message types are in different namespaces. The problem is that the lookup is...

ruby codegen: support generation of rbs files

@HoneyryderChuck can you rebase and we'll try the tests again?

Allow builders to return default instance in Java

@yuzawa-san Unfortunately, while we like the idea, we can't absorb this change. We've actually attempted this internally and there are currently a bunch of tests that rely on `.newBuilder().build()` returning...

PHP: Deprecation message for "return_immediately" is thrown which is impossible to fix

@fowles has taken on expanded scope. I'm taking on his role on the protobuf team. Experience with doc comments is that they are ignored -- a reasonable amount of log...

Enum definition with a value "VALUES" generates code that fails to compile in Java

Ideally, that would be the case. Unfortunately, there are cases within Google that use reflection to get to some of these fields by name. I need to verify that changing...