Jerry Berg comments

Results 85 comments of


                                            Jerry Berg

Enum definition with a value "VALUES" generates code that fails to compile in Java

Hi @dcitron, unfortunately, the "VALUES" field is accessed refectively inside of Google. I will file a bug to clean up those uses and then change the name.

Enum definition with a value "VALUES" generates code that fails to compile in Java

Unfortunately, we have not yet had the bandwidth to do the prerequisite cleanup to do the fix.

Naming convention for function names doesn't make sense

Hello @Sereger13, Actually, we recommend that you create a unique request and response proto for each RPC method. Discovering later on that you need to diverge the top-level request or...

Naming convention for function names doesn't make sense

Definitely on the right track. Let's try something a little more concrete like this: ``` service StudentService { rpc CreateStudent(CreateStudentRequest) returns (CreateStudentResponse); rpc GetStudent(GetStudentRequest) returns (GetStudentResponse); } message StudentID {...

[Java] The release notes state that compatibility was restored in v27.2, but it is not compatible

Hello Community, Yes, we've added more-complete shims in PBJ 4.28.0-rc3. We will also be cherrypicking the shims into a new patch release 4.27.4 (coming soon). If possible please try out...

[Java] The release notes state that compatibility was restored in v27.2, but it is not compatible

Excellent. Thank you @be-hase, @ejona86 , @bjoernmayer, and @emintz for verifying. Big thank you to @zhangskz who made the fixes happen. Happy buffering.

[python] Remove explicit visibility("default") on PyInit__message

@haberman this looks like a fairly simple review

[7392] [cpp] Fix IgnoreUnknownEnumStringValueInMap conformance tests

@esrauchg Can you take a look at this?

Fix compiling problems with lua 5.4

Apologies for the dead air. For some reason tests never ran. Unfortunately, it looks like this PR will need a rebase and some merge conflict resolution.

[python] Remove semicolon after `PyObject_HEAD`

@ericsalo is going to take a look at whether the clang formatter can be satisfied.