Jerry Berg comments

Results 85 comments of


                                            Jerry Berg

Deprecated field PARSER is accessed in generated code

Consider a breaking change in the Java API in a future release to make this static object private.

JsonFormat.Printer serializes custom options, but JsonFormat.Parser fails to deserialize them

This is unsupported with the current API because it requires an ExtensionRegistry, but extensions aren't really supported in proto3. This needs further thought.

Inconsistency occurs in Java Proto builder when calling build() after clear()

@choxsword I can see the behavior you describe, but I'm curious what negative impact you see from the inconsistency.

Inconsistency occurs in Java Proto builder when calling build() after clear()

@choxsword nm, I think I see what you are saying now. It creates a stale cache problem.

Inconsistency occurs in Java Proto builder when calling build() after clear()

Hi @choxsword, yes, I have a fix for this, it won't be in the next release, but the one after.

Update hash for 21.8 release

done

Enable RBE using bazel's rbe_default toolchain.

@dlj-NaN Should we do something with this or close it out?

Annotate nullability in generated code

protoc generated java code annotates non-null APIs with @com.google.protobuf.Internal.ProtoNonnullApi

Annotate nullability in generated code

My mistake. I thought these annotations were also in OSS. We should use the standard annotations rather than our custom ones.

[Java] [Request] Add @Nullable annotations to java code.

We should be using the javax.annotation.Nullable