Edwin N Gonzales

Results 12 comments of Edwin N Gonzales

@reichie020212 please check the test errors

@celinenilla Considering that the findings of the QA is more on the user roles and access rights, I suggest that we merge the PR now and that new tickets be...

Proposed solution: - Add a sequence field in "ir.model.fields" and will be used as the default sort order. - Customize the "ir.model.fields" tree view in spp_custom_fields_ui to provide a handle...

Yes @kneckinator . I will check this today.

> > Yes @kneckinator . I will check this today. > > Great @gonzalesedwin1123 . Did you find anything or can this be merged? @kneckinator I just requested for changes...

> ## [![Quality Gate Failed](https://camo.githubusercontent.com/ce402bcc4cf818eda660128f0b27a891eb8c9f4e0d783303ea667cb0d4b07f95/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d6661696c65642d323070782e706e67)](https://sonarcloud.io/dashboard?id=OpenSPP_openspp-modules&pullRequest=782) **Quality Gate failed** > Failed conditions ![](https://camo.githubusercontent.com/bd1d5234b37410841ad8cd9d85c84eeecaec92ae18a95c926ae3a59a17c29a65/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6661696c65642d313670782e706e67) [24 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=OpenSPP_openspp-modules&pullRequest=782&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/bd1d5234b37410841ad8cd9d85c84eeecaec92ae18a95c926ae3a59a17c29a65/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f6661696c65642d313670782e706e67) [7.2% Duplication on New Code](https://sonarcloud.io/component_measures?id=OpenSPP_openspp-modules&pullRequest=782&metric=new_duplicated_lines_density&view=list) (required ≤ 3%) > > [See analysis details on...

@kneckinator I think this PR is OK. Do you have other concerns? Otherwise, I can merge this to 17.0 but this will not be included in the Ticao release.

@emjay0921 please check the conflict

@celinenilla Considering that the findings of the QA is more on the user roles and access rights, I suggest that we merge this PR now and that new tickets be...