openspp-modules icon indicating copy to clipboard operation
openspp-modules copied to clipboard

[IMP] Icons

Open emjay0921 opened this issue 7 months ago • 2 comments

Why is this change needed?

To improve the icons for Menus for SP-MIS and SP-Farmer

How was the change implemented?

Changed the menus icons via XML Data, inheriting/overriding the Menus' Icons

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • After Deployment on SP-MIS or SP-Farmer Instance.
  • Check if all the icons of the menus are now white lined.

Related links

https://github.com/OpenSPP/openspp-modules/issues/802

emjay0921 avatar May 15 '25 06:05 emjay0921

Codecov Report

:x: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 77.90%. Comparing base (f172ecf) to head (02ae944).

Files with missing lines Patch % Lines
spp_registry_base/models/ir_module_module.py 84.21% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #809      +/-   ##
==========================================
+ Coverage   77.88%   77.90%   +0.01%     
==========================================
  Files         763      765       +2     
  Lines       19853    19886      +33     
  Branches     2383     2386       +3     
==========================================
+ Hits        15463    15492      +29     
- Misses       3835     3838       +3     
- Partials      555      556       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 15 '25 07:05 codecov[bot]

@claude review this PR

jeremi avatar Jun 17 '25 20:06 jeremi

Claude encountered an error —— View job


I'll analyze this and get back to you.

claude[bot] avatar Jun 17 '25 21:06 claude[bot]

@claude review this PR

jeremi avatar Jun 17 '25 21:06 jeremi

Claude encountered an error —— View job


I'll analyze this and get back to you.

claude[bot] avatar Jun 17 '25 21:06 claude[bot]

@emjay0921 please check the conflict

gonzalesedwin1123 avatar Sep 15 '25 03:09 gonzalesedwin1123