Gary O'Neall

icon indicating a website link sourceauditor.com icon indicating an email [email protected]

icon company Source Auditor Inc. icon location San Francisco Bay Area icon location Contributor to Linux Foundation @spdx and @OpenChain-Project projects. Consultant providing technical due diligence and open source compliance services.

Results 1059 comments of Gary O'Neall

Stable Semantics over Oprimization of Representation?

Note that the specific topic under discussion was decision to use relationships for licenses rather than properties.

Add missing para of JSON-LD context section to Model and serializations chapter

Holding off on merging this until the tooling (shacl2code) implements the additional namespaces. @JPEWdev @goneall will look into this

Deadlock in ListedLicenseWebStore

The simplest solution would be to just hold write locks instead of readlocks, but that would negatively impact concurrency.

Column in DifferenceDescription returned by LicenseCompareHelper.isTextMatchingTemplate is not correct

Thanks again @sdheh for the analysis. Pull requests are welcome - otherwise I'll look into a fix after finishing the SPDX 3.0 upgrade work.

Column in DifferenceDescription returned by LicenseCompareHelper.isTextMatchingTemplate is not correct

@douglasclarke - do you think this is fixed with #310 ?

Column in DifferenceDescription returned by LicenseCompareHelper.isTextMatchingTemplate is not correct

Thanks @douglasclarke - I'll go ahead and close this issue as resolved.

Column in DifferenceDescription returned by LicenseCompareHelper.isTextMatchingTemplate is not correct

> One comment I would make is that the fix in [#310](https://github.com/spdx/Spdx-Java-Library/pull/310) is based on the current implementation of LineColumn and src/test/java/org/spdx/licenseTemplate/LicenseTextHelperTest.java of spdx-java-core. I did test with trying to...

TemplateRegexMatcher.getStartRegex sometimes returns a regex that matches with an index before the license start

Now that I review this issue, I do tend to agree that this is an issue if the method is being used without following on with the template matcher. @sdheh...

CompareTemplateOutputHandler.compareText returns incorrect match token

Thanks @douglasclarke for reporting this. If you could create a PR, that would be much appreciated.

CompareTemplateOutputHandler.compareText returns incorrect match token

Thanks @douglasclarke - That should work