Michael Goderbauer

Results 295 comments of Michael Goderbauer

(triage): Spoke to @bkonyi last week and he promised to get back to this before he retires.

Note: This data was missing from our ICU even before the recent attempts to reduce ICU size. The data is missing from Chromium's Android ICU configuration [1] that we have...

Shipping different versions of the ICU for different platforms is what chromium did back in the days when I first looked at this (looking briefly at https://chromium.googlesource.com/chromium/deps/icu/+/refs/heads/main/README.chromium it still looks...

> Could you check what's failing in Google testing and if it's a big deal? Else the bigger change might trigger more things. You'll have to rebase this PR to...

@lijianqiang12 Hello and thanks for the contribution. Do you still have plans to come back to this, address the feedback given above, and add a test?

Along side the other time picker test would probably be best: https://github.com/flutter/flutter/blob/master/packages/flutter/test/material/time_picker_test.dart

You can already do this today by wrapping your Listenable in another listenable that only notifies their listeners when the condition is met. I don't think we should add specific...

I still don't think we should add this to the framework as a doc comment is easy to miss and it is an API that can have surprising side effects....

So far, this hasn't been a huge problem in the Flutter repository. I can't remember the last time I had to ask in a code review to change the order...