Michael Goderbauer

Results 295 comments of Michael Goderbauer

I do like the idea. In my reviews I have always been encouraging people to put the text from the deprecated annotation also in the doc comment itself, precisely because...

This whole investigation was triggered because in flutter we removed a bunch of `// ignore: avoid_redundant_argument_values` warnings that didn't appear to ignore anything and the PR was analyzer clean locally...

> What should happen here? The parameter is nullable, so passing null is not necessary. But the parameter is also required, so we have to provide something, e.g. null. So,...

It's complaining about this line here: https://github.com/flutter/flutter/blob/49fbf19590fd206af1a78cde93ffba9eeb6bcc0f/dev/integration_tests/android_semantics_testing/lib/src/tests/controls_page.dart#L71 But `onChanged` is a required argument, removing it triggers the `missing_required_param` warning. So the lint there again is bogus and shouldn't really be...

Have a look at the scopesRoute and namesRoute options of the Semantics widget. Those values are used to indicate to TalkBack that the route visible on the screen has changed...

> What about Localizations.localeOf? +1 to that. This sounds like the right hook for the issue.

@rj-since-2000 while that PR will restore the garden when the OS kills the app while running in the background, it will not persist your favorite veggies when the user actively...

> dark/light mode, adjust text scale, switch target platform Two if these are already exposed on the command line when you do a `flutter run`. From the help command: ```...

> if I launched my app from VS Code, how would I access this functionality? I am not familiar with the VS Code plugin, so I don't know if the...