Michael Goderbauer

Results 448 comments of Michael Goderbauer

[ffigen] ObjC example imports `package:ffi` unnecessarily

We already generate `// ignore_for_file: type=lint` to disable lints. As a work around and to avoid that people individually have to deal with this, should we extend this to also...

[ffigen] ObjC example imports `package:ffi` unnecessarily

I am implementing that work around in https://github.com/dart-lang/native/pull/2750.

[hooks] Specify exit-codes and add status field to output

The proposal sounds good to me.

Added missing test for SelectionArea example

(triage): @iam-amanxz Do you still have plans to come back to this PR to address the feedback given above?

Fix SliverAppBar Stretch Not Triggering in NestedScrollView

(triage): I am going to close this based on the discussion above.

Failed assertion: line 2283 pos 14: '_debugSubtreeRelayoutRootAlreadyMarkedNeedsLayout()': is not true

Thank you for the report. To debug this it would help if you could reduce the test case more, see https://github.com/flutter/flutter/wiki/Issue-hygiene#provide-reduced-test-cases

Allow the condition part of a split conditional expression on the same line as an assignment

I would prefer keeping the condition on the same line. I also find it looks more visually pleasing, particularly in widgets trees.

Exclude focus for hidden children in an IndexedStack

@skimm3 Do you have plans to come back to this PR to address the feedback given above (i.e. making this non-breaking by making the new behavior opt-in via a flag)?