Michael Goderbauer

Results 448 comments of Michael Goderbauer

I am ok with leaving them named, but then I think the `unnecessary_library_names` lint is broken since the library name isn't unnecessary. It's there for docs.

@a-wallen @gspencergoog You recently did some work in the adaptive layout space. Anything worth mentioning here?

Looks like we need to update our transition. @HansMuller Is this already on the list of remaining work for M3?

@bkonyi and I talked on Friday and we had the idea that what lives in the framework would ideally be fairly minimal. Maybe just the annotation and a WidgetPreview data...

@LongCatIsLooong looks like some line numbers are off in tests: ``` 00:10 +67 ~3 -1: test/analyze_test.dart: analyze.dart - clampDouble [E] Expected: '╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════\n' '║ packages/flutter/lib/bar.dart:37: input.clamp(0.0, 2)\n' '║ packages/flutter/lib/bar.dart:38: input.toDouble().clamp(0,...

(triage): https://github.com/flutter/flutter/commit/8d01fe0565e41ff1ad1b12bd6141fe636d1dc973 still hasn't made it to stable.

> As url_launcher is a plugin that includes native code, we'll need to figure out a way to vend such plugin with the Flutter SDK. Would we just build the...

> is very hard to debug because the code is too convoluted. I 100% agree with this. This is getting very complex and I am not confident that we are...

I spoke to @justinmc and he said this is back on his radar.