Gloria Zhao

Results 310 comments of Gloria Zhao

Thanks @dergoegge, will spend some time thinking about whether there are any problems with it. Perhaps we can do this easier version now and cross the orphan reso tracker bridge...

The 2 main functional differences I noticed with this approach are (1) If there are multiple missing parents, we may be using different peers to request them. (2) We don't...

Thanks for the reviews @mzumsande @instagibbs! Just got back from holiday, addressed all the comments. Biggest change was recalculating missing parents each time we add a new orphan reso candidate....

> I wonder if it's possible to avoid keeping track of the announcers in `m_orphans`, as I think it should match `m_txrequest.GetCandidatePeers(orphan_tx)`? That's true immediately after receiving the orphan, but...

Followup #31666 wraps up all the comments here except for 2 things which might be a little more involved: https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1902153685 (because we need to add a txid index) https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1919108948

The idea of only using BIPs for standards that need to be adopted by "everybody" or are consensus rules has no precedent and makes no sense. There are lots of...

> > What is the rational to limit ephemeral outputs to being spent by transactions adhering to the TRUC standard? The goal of ensuring that dust outputs are immediately spent...

Thanks @murchandamus, took all your suggestions (4bd12d5...af8e903)

@luke-jr this has been open for a month, would you mind taking a look?

Addressed @murchandamus's comments and slightly restructured the text. > As with https://github.com/bitcoin/bips/pull/1524, node policy is not a standardizable subject matter in itself - every node decides its own policy. I...