Gloria Zhao
Gloria Zhao
@sipa Makes sense, thanks for explaining!
ACK 3add234546 - I can't say I have a complete mental model of every possible interaction during IBD, end of IBD, reorgs, etc., but whiteboarded the syncing logic to the...
> In the second commit, the default constants are deduplicated by moving them into the messages.py module. (Not sure if this module is really appropriate, as it doesn't have a...
@naumenkogs Ah thanks for linking me! Sorry for missing that. Fwiw, I believe that "even if tx relay is enabled via a bloom filter later, for these nodes reconciliation is...
Concept ACK. AFAICT this is preferred and for this reason, so might as well document it.
Concept ACK, nice
> Another alternative: delete the details from BIP125. The only interesting thing in it is the opt-in part. The rest was just suggestions for how to implement RBF that have...
> I don't know why references to BIP125 have to be removed from the comments. The comments can (and should) refer to BIP125 e.g. BIP125 rule X and explain what...
> Oh great! It wasn't clear to me from the first post's description that this already existed—you could perhaps highlight that more in the first post. Thanks, done! > if...