Gloria Zhao
Gloria Zhao
> > redownloading orphans if we cannot afford to protect them > > Is the idea here that protection is a bandiwdth optimization to avoid fetching an orphan twice in...
Thanks everyone for the reviews! Last push: - Implemented changes that were discussed on the BIP PR https://github.com/bitcoin/bips/pull/1382 - Maximum of 100 transactions per `getpkgtxns` request - Changed `versions` field...
> I suspect this implementation, with an absurdly high ancestor chain limit being set, would violate the 100 txn limit for getpackagetxns: https://github.com/bitcoin/bips/blob/02ec218c7857ef60914e9a3d383b68caf987f70b/bip-0331.mediawiki#getpkgtxns Are you sure? We still require an...
Added check that outbound `getpkgtxns` is
Not intended for merge. Not planning on rebasing right now since this should be built on top of cluster mempool and other WIP projects.
Ok Drahty I'll take the hint :joy:. Most of the code here is in master now - the Orphan Resolution Module is part of `TxDownloadManager` (#30110, #31397, etc.) and the...
concept ACK
Thanks! I've added magnet link, fixed @katesalazar's comment, and edited the dates to be today.
reACK 940edd6 via range-diff
Tend to agree with the "let's wait for cluster mempool, which is currently our only proper solution to the problem" approach. My reasoning for #23121 was also that (1) rule...