Gloria Zhao
Gloria Zhao
Rebased for silent merge conflict with #32406
Rebased and edited the functional tests for silent merge conflict with #32421
> As soon as the victim package is spotted, the attacker sends their own "honest"-yet-evil cpfp packages, 404kWU total, at mempool minfee. The FIFO behavior kicks in, and the victim's...
Needs release note?
> This may however cause issues for orphan resolution in adversarial situations, since fetching the parent is done using its txid. Greg Sanders pointed out to me on IRC this...
> Since wtxid-relay was introduced a new form of "txid-based transaction resolution" was introduced with 1p1c package relay No, txid-based orphan resolution has been around for many years - I...
> Couldn't AlreadyHave() be tweaked to optionally not look up the reject filter: I assume you mean just for the check that filters `getdata`s. That means we'll then request transactions...
Thanks for writeup @darosior 👍 > This is not a concern anymore because wtxid-relay was released on 2021-01-15 with 0.21.0. Nowadays, virtually all connections on the network are wtxid-relay. Digging...
Following up, this branch removes the logic to halt orphan-processing when there are rejected parents, and removes rejection cache checking by txid altogether. It also adds a new delay for...
I ran the above patch for a while and added logging to collect some stats and see how much more redownloading we’d do. TLDR it seems like we can definitely...