Gloria Zhao
Gloria Zhao
Planning to rebase on master along with #30111 when it's merged
Rebased, ready for review.
Rebased for #30413
Would it help if I put the test/fuzz changes in a separate PR from the refactoring changes? It would make the first PR less exciting to review, but perhaps easier...
> > to you, but there is a small benefit of going with the fuzz tests first (if possible) > > It looks like the tests here mostly operate on...
> I don't think we want to merge the other commits unless the fuzz harnesses are attached to it. I'm continuing to review either way. Ok sounds good, I'll leave...
> TESTED_TX_RESULTS is missing TxValidationResult::TX_RECONSIDERABLE That's an oversight, I've added that and UNKNOWN now which should mean we see packages.
> Find1P1CPackage doesn't actually check the normal reject filter at all with respect to the child, only reconsiderable, so that assertion gets hit. I think it might be more that...
Thanks @dergoegge @theStack @instagibbs! Addressed all comments. > Slightly off-topic, but: on some commits like https://github.com/bitcoin/bitcoin/commit/4e58d84da95d97d64f563b5c3e116769cd9ff89b --color-moved=dimmed-zebra didn't detect any lines as move-only for me (with 2-3 exceptions that seem...
Rebased for cmake