Gloria Zhao
Gloria Zhao
> FWIW I tried something similar, and got an assertion failure in one of the mempool functional tests (maybe mempool_reorg, and thus due to an invalidateblock call?) Was it mempool_packages.py...
Rebased for #29817
Thanks @vasild. I will take your suggestions in a followup or if I retouch this.
> Changes like this are inherently difficult to review Yes, needs careful code review. The intermediate `Assume` in 4673e04cb3 may help as a sanity check. Lmk if anybody has ideas...
Addressed @dergoegge and @vasild comments. Ready for review again, reACKs would be appreciated!
- Updated the PR title and description, thanks @mzumsande - Rebased for #30394 - Renamed variable https://github.com/bitcoin/bitcoin/pull/30111#discussion_r1665560023 - Added some more documentation to `m_tx_download_mutex` to address https://github.com/bitcoin/bitcoin/pull/30111#discussion_r1678336506.
> In the master branch, the design of the TxOrphanage class is thread-safe for all purposes. I don't think that the fact that m_orphanage does not require additional synchronization justifies...
Rebased for #29817 and added a "ensure we can always download a tx as long as we have 1 good outbound peer" fuzz test