glorv

Results 69 comments of glorv

> Well, I changed the checker `unblocksBetween`, when it failed, it would print the real duration it cost to got the `waitgroup` unblocked. > > With this version, I will...

Another failed case: https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/br_ghpr_build/detail/br_ghpr_build/3316/pipeline Seem waiting for `800ms` still can't avoid this issue. ``` [2021-03-10T10:51:05.341Z] ---------------------------------------------------------------------- [2021-03-10T10:51:05.341Z] FAIL: pause_test.go:67: pauseSuite.TestPause [2021-03-10T10:51:05.341Z] [2021-03-10T10:51:05.341Z] pause_test.go:106: [2021-03-10T10:51:05.341Z] // Give them more time to...

> lgtm. do we need pick to 6.0? This is a manually cherry-picked pr as br code with version < 5.2 are still in this repo.

@3pointer Do we still need to cherry-pick this PR to `release-4.0`?

I think we should also add `br` version into backup meta