br icon indicating copy to clipboard operation
br copied to clipboard

pdutil: use the correct unit for pausing schedulers

Open glorv opened this issue 2 years ago • 3 comments

What problem does this PR solve?

ref: pingcap/tidb#33546

What is changed and how it works?

cherry-pick pingcap/tidb#33545 to br

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that the schedulers won't be resumed after BR/Lightning exits abnormally.

glorv avatar Mar 30 '22 02:03 glorv

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot avatar Mar 30 '22 02:03 ti-chi-bot

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm. do we need pick to 6.0?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Mar 30 '22 08:03 ti-chi-bot

lgtm. do we need pick to 6.0?

This is a manually cherry-picked pr as br code with version < 5.2 are still in this repo.

glorv avatar Mar 30 '22 08:03 glorv