br icon indicating copy to clipboard operation
br copied to clipboard

tests: stop all fake-gcs-server and oauth during stop services

Open overvenus opened this issue 3 years ago • 12 comments

What problem does this PR solve?

This PR tries to prevent fake gcs server port conflicting by randomlize port number.

Close #795

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

overvenus avatar Mar 12 '21 02:03 overvenus

/lgtm

lance6716 avatar Mar 12 '21 03:03 lance6716

/lgtm

glorv avatar Apr 21 '21 05:04 glorv

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment. Reviewer can cancel approval by writing /lgtm cancel in a comment.

ti-chi-bot avatar Apr 21 '21 05:04 ti-chi-bot

/run-all-tests

glorv avatar Apr 21 '21 05:04 glorv

/merge

kennytm avatar Apr 21 '21 19:04 kennytm

/run-integration-test

kennytm avatar Apr 21 '21 19:04 kennytm

/run-integration-tests

YuJuncen avatar Apr 23 '21 06:04 YuJuncen

/run-integration-tests

kennytm avatar Apr 23 '21 19:04 kennytm

@overvenus: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot avatar Apr 25 '21 09:04 ti-chi-bot

/merge cancel

i think we need to check if the errors are really spurious

kennytm avatar Apr 25 '21 10:04 kennytm

Still working in progress?

lonng avatar Jul 07 '21 06:07 lonng

/run-all-tests

glorv avatar Jul 07 '21 14:07 glorv