David Glasser

Results 444 comments of David Glasser

The top-level playground option was removed in AS3. (I recommend using TypeScript which would have made this into a clear compile error.) See the migration guide for how to re-enable...

Will try to take a look at this soon, though the understanding of the intricacies of Fastify on the core team is limited. I'm planning to put together a proposal...

We agree that it's reasonable to get a full GraphQLRequestContext for all request-based hooks and to be able to use async functions. In fact, that's how the plugin API works;...

Specifically we should: - Do *some* level of CI so that there's any validation at all that the examples run. (Porting to TS might help!) - Enable automerge

This was caught by our internal `inconsistent_reports_records_in_gcs` monitor in staging, which we should re-enable once this is fixed.

This surprised me today! Good thing I usually read implementations and not just docs...

I reproduced the issue. @SimenB https://github.com/facebook/jest/pull/12954 is the thing most coverage-related in [the diff](https://github.com/facebook/jest/compare/v28.1.1...v28.1.2)

@SimenB Our resolution was to stop running with `--coverage`: https://github.com/apollographql/apollo-server/commit/4225ba6347f7e57e672a2f965f38ac7a6df914ed

@SimenB The commit I linked is on the `version-4` branch which is where a bunch of our active development is happening. Guessing the issue is only occurring there.

Right now, `version-4` is our active development branch (`main` is our stable branch).