Goktug Gokdogan

Results 117 comments of Goktug Gokdogan

ES6 Class field initialization is a non-finalized spec (Level 3 as of this writing) and not supported by Closure Compiler yet. If you like you can file a bug there...

JsChecker uses JsCompiler directly so there should be no behavior difference which suggests that you are very likely testing with a different version of JsCompiler than the one used current...

Ok the behavior difference is then probably due to selected language from JsChecker: LanguageMode.ECMASCRIPT_2017 while using JsCompiler. It should be using ECMASCRIPT_NEXT or STABLE_IN to not fall behind. You can...

Got it; need to dig where the exception escapes. Re-opening the issue.

I reproduced the issue with Closure compiler; you need to pass `--continue_after_errors`; that is the parsing mode that is used for checking but not enabled by default on command line...

Is there any particular reason that you want to use aspects here? They are complicated and only useful if you like to overlay on top of other rules that you...

There hasn't been any activity in this PR for very long time. Please let me know if there are any intentions to pursue this change. Otherwise I will close it....

I think this is related to one of wrong term direction discussions for rules_closure. I think this repo should solely focus on providing a slim compatibility layer around closurized JS...

@sgammon Thanks for your detailed reply and your honest feelings about this. I appreciate that and I also definitely empathize with your overall experience. Let me quickly clarify; I am...

(And FWIW, since you linked above to https://github.com/google/elemental2/issues/119; we proposed a good alternative and you said you will follow up with such a PR but didn't 🙂)