Goktug Gokdogan

Results 117 comments of Goktug Gokdogan

I'm not completely against it but maybe somebody could contribute a GWT compiler optimization instead?

I'll re-open this since I noticed we have some patterns that doesn't optimize in J2CL. Either we should improve optimizations or change the implementation.

IIRC, we discussed earlier that externs should not have enum definitions. if we are not handling the correctly we should probably have a good warning about it. I think Closure...

I don't think Google Maps vs Browser change things much. I think it is still controversial to define enum in this case; this is because the extern should never be...

I'm not following most of your questions/conclusions. You can just send a patch to closure extern to make it a number.

Yes, that's what we were told earlier.

jsinterop generator could generate the support calls while externally it could be provided by elemental2 for which APIs to generate it for. Being said that, in jsinterop-base we can probably...

Yes, isExtern method there should be renamed, it is not really related Closure extern. Starting from Closure then using tsickle back and forth to generate js externs to generate Java...

Yes, it never matters for GWT2 because for GWT2 all javascript is external. For J2CL, some JavaScript is external some is not. External is code is that that is not...

goog.global is the replacement. `self` unfortunately doesn't work in node.js environments. We added goog.global to GWT earlier so we could update the code generation. (https://github.com/gwtproject/gwt/blob/4825d47eee7505346de372a159db55b18b006a2a).