Goktug Gokdogan

Results 117 comments of Goktug Gokdogan

Thanks Colin. Couple of comments: We already have test targets, we didn't publish them because there is no macro to run tests (i.e. gwt_test). So we actually need the macro....

> GetArgumentsHelper needs to be annotated as @JsType Why is that?

@ekuefler we released J2CL couple of months back. Today @sarsonj asked about Guava Eventbus (https://github.com/google/j2cl/issues/29) and I pointed to your project. It might be a good time to port the...

Thanks for the detailed report. Would you like to send a PR?

Sorry didn't read the whole thread yet but taking a quick; seems like you are using goog.module. goog.module doesn't work with @define; pls use goog.provide instead.

Pls change ```app.version = goog.define('APP_VERSION', 'alpha');``` to ```app.version = goog.define('app.version', 'alpha');``` System.getProperty uses the name passed to goog.define. Also you can simplify your setup like following: ``` j2cl_library( name =...

Thinking about it; it is easy introduce a Bazel macro to streamline this.

There is tags "manual" on that target. That shouldn't build unless you specifically ask it to do. What exact command are you running? Is there anything special in your bazelrc?