hulk

Results 524 comments of hulk

> @ShooterIT @git-hulk I'm unfamiliar how `redis_deferring_client` works. Could you give some background here? > > @suica for raw client, in #888 I write a `WriteArgs` method for easily writing...

The main concern from my side is that C++17 may be too new for many users, and RocksDB 7.x is too radical since it should NOT have enough users now....

> > > During sending snapshot, exipre time of some key may be changed to larger by clients. GetMetaData is needed to deal with this case. > > > >...

Yes, the root cause is the snapshot can be different between writers and background threads. I prefer to use current implementation, then we can try to seek another way to...

Thanks for your feedback. Maybe we need a smarter compaction strategy which can compact range in-flight when finding there're too many deleted or expired tombstones.

We didn't have the recursive delete directory yet.

@Napoleon0621 Can leave this in low priority

Currently, revive supported the ignore list but it used AST subtree to match the ignore function name. For example, we need to add `b1.WriteString` to the ignore list: ```Go var...

@chavacava How do you think about the above solution?

> Trying to handle all cases by matching strings will necessarily be an incomplete and uncomfortable solution. For example, using string matching to ignore the following call > > ```go...