hulk
hulk
> I think we can merge it now since the benchmark looks good. Yes
Thanks all, merging...
Thanks to @wanghenshui contribution again.
Thanks to @torwig great contribution. For the replication part, Kvrocks will replicate the data after writing into db, so we needn't to do anything if it has no special case....
> @git-hulk I mean that if I run `XREAD BLOCK 0 STREAMS s1 $` on a replica (it will block) and then execute `XADD s1 * k1 v1` on master...
> @caipengbo Added design notes. Many thanks to @torwig detail explanation and bring this good feature into Kvrocks community, we will take a look recently.
I took a look briefly and overall design is good to me. There are two small issues in design internal: 1. I think we should save the entries number as...
> > I took a look briefly and overall design is good to me. There are two small issues in design internal: > > > > 1. I think we...
> > > > I took a look briefly and overall design is good to me. There are two small issues in design internal: > > > > > >...
> @git-hulk Added batch handling on replicas to unblock clients that were blocked by the XREAD command by the respective XADD. Thanks for your great contribution, I will try and...