kong icon indicating copy to clipboard operation
kong copied to clipboard
verified publisher icon Kong

fix(router/atc): uri replace didn't works well if contains the optional group

Open git-hulk opened this issue 1 year ago • 3 comments

Summary

URI captures are not usable if the first capture is an empty string.

Checklist

  • [x] The Pull Request has tests
  • [x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Ticket reference

Fix #13014, KAG-4474

git-hulk avatar May 13 '24 12:05 git-hulk

This PR is ready to review now. Could you please take a look while you have time? I'm not sure if I get your point correctly.

git-hulk avatar May 13 '24 14:05 git-hulk

@StarlightIbuki Thank you, I did enable the .editorconfig plugin in my IDE, but it seems didn't work correctly. Will take care of this next time.

git-hulk avatar May 14 '24 07:05 git-hulk

@StarlightIbuki @chronolaw Please take a look at the last commit again.

git-hulk avatar May 14 '24 09:05 git-hulk

@dndx @nowNick @ADD-SP @samugi Would you mind taking a look again?

git-hulk avatar May 27 '24 05:05 git-hulk

Successfully created cherry-pick PR for master:

  • https://github.com/kong/kong-ee/pull/9253

team-gateway-bot avatar May 27 '24 07:05 team-gateway-bot

Thanks all for your help!

git-hulk avatar May 27 '24 07:05 git-hulk