Gabby Getz comments

Results 774 comments of


                                            Gabby Getz

Enable eslint-jsdoc

This needs a merge. I'm closing until I get the chance.

scene.sampleHeight cause polygon(clamp to ground) to flicker at top view

Interesting, I'm not able to reproduce on my machine. Would you mind leaving the Chrome version you're seeing this on? Also, could you please visit webglreport.com and take a screenshot...

scene.sampleHeight cause polygon(clamp to ground) to flicker at top view

Thanks @GatorScott! I see the issue know. It looks like it may be an issue with the shadow volumes used for ground primitives.

subsequent pickPosition returns wrong value (depth?)

Thanks for all the debugging here @UniquePanda. From my understanding, the root cause of this issue is likely https://github.com/CesiumGS/cesium/issues/4368, however this only arose in point clouds once the Model reactor...

subsequent pickPosition returns wrong value (depth?)

Got it, thanks for pointing this out @anne-gropler. Reopening.

Cesium3DTileset modelMatrix reset error

@slimkevo Sounds good!

Cesium3DTileset modelMatrix reset error

Hi @slimkevo, is this code snippet intended to reproduce the issue, or to solve the issue? I would generally not recommend recreating the tileset unless it's for debugging purposes only....

pickTranslucentDepth Crashes Cesium

Hi @cyber-tomahawk, I am able to reproduce the error. I can confirm that the error is caused by accessing resources which were destroyed in a previous frame. However, I think...

pickTranslucentDepth Crashes Cesium

@lilleyse Do you have any insight as to why setting `pickTranslucentDepth` may interfere with globe tile processing?

pickTranslucentDepth Crashes Cesium

In the meantime @cyber-tomahawk, would you mind elaborating on the reason `pickTranslucentDepth` is needed? There may be possible workarounds, such as using `drillPick` or turning on `pickTranslucentDepth` before the needed...