Gabby Getz comments

Results 774 comments of


                                            Gabby Getz

Supporting picking properties from property textures

Thanks @javagl! Closing this in favor of https://github.com/CesiumGS/cesium/issues/12225.

Invalid requests sent out for voxel content

@jjhembd Could you please triage?

Invalid requests sent out for voxel content

Hi, @jjhembd – Just a reminder to please take a look and triage this issue.

clamp_to_ground doesn't work, point can't clamp to 3dtile

Hi @YHLpuyu, clamping is not enabled on all 3D Tiles by default for performance reasons. You'll need to provide the option `enableCollision: true`. See [this updated example.](https://sandcastle.cesium.com/index.html#c=zVVtbxo5EP4rFuqH5UQNgRBIDqKjQC6rIxCFbaJKSNR4B9aq117ZXkha8d/P+5bspvR0H8sX7JnnGT8zY89SKbRBewYHUGiIBBzQGDSLQ/yY2pxVjab7sRSGMAFqVWugHyuBkAGlrOWqIHjZHm+VDJ+k4n5ucOqNlTjW/1yJ7BisKQjAOy43gH2ITOCBNqOdhWqTc6wUo2KwnGbzBEsH8jDcEq4ThFEvmSCa5mIYBw3GRiAHwkyhLvvrTLzMnap0pRhpu3F957zVv7jIEwNBNhzGknOmmbQJJlISR5oEQhVBkWIhM2wPGhPfd/LTK8DvUoaeLLuOiBJDA+TYbKWqv8mXHDCXO+frNHEgLonPxK7I6Qp9+JEyjl+zKCthi0oUCojw+fsGLqkCEMuIUJjuQZjbDORU5FNiA+hMbh4FJxURUWxG1Nj0nW0s0gVyQrmH0EbKBRcVP0TDakkY/XYvNUvZBQdHuSU7q+BSoowcFj1KNjtFooDRtEGJwbqIcA5RmVeUKWXbldgxE/vwx1m/1bwjJsD37n/AifkF+tj4Ve28lwjwbHrjrcczd/xPAl+JLAP+rG3d8wJYqE0yvwt5kZKfICFcoVXNgu37ebMXRXl9RK8Zd9ICTGBnhWjnY6+Lu5e9drvXOu+322fdTgOdt3Cr07/od3qXvYtW57JbrwRmwt6XkgRrY8/Al+y7VdJtlB1UcqneJCQ7/DCdVDAyNtw+//EJ6NOt601PgZ+Yb4Ir1K74AmC7wDzAFhQICq+xbqt2PJ6N7u7X3mL998Pi87wqxmc6eaKTYnhMmDYkDTaPw43tw/1i6Xru43Ttzm/cuet9KdGPpTUnG+DvymTg2ZzqFUJbKVLP2XlkUCiF1MkFeQfS5oW/ZTVLDlgmJnzjzmbr0XyyXnz2Zu78/1dsD8owSvhCsV1p3j5WzPjTwvMWd42fGr7YbtPRUZoMr5es7bQa6ONl/TdrULG087bWqA3Sil4Xxr9YGEllUKy4g3HTQBjZFw26uYnpNzvYqdbF2x80y9SBz/aI+cMTXzREOdHaerYxT1/IqnY9aFr8T9R8Ii9sTzh5SWDB2fUsM2KMB027Pc00UvINUe8i/ws)

Make sampleTerrain behaviour consistent with the rejectOnTileFail flag

Thanks @jesseyay! We'll review shortly with the intention of including this in the next CesiumJS release.

Make sampleTerrain behaviour consistent with the rejectOnTileFail flag

Thanks @jesseyay! The code changes here look great. Do you or @chris-cooper have any thoughts about reversing the default of `rejectOnTileFail` to `true` given https://github.com/CesiumGS/cesium/issues/11694? That would restore behavior that...

Make sampleTerrain behaviour consistent with the rejectOnTileFail flag

Got it, thanks for looking into that @jesseyay! Sounds like we'll need to look a bit closer to find the source of the regression. No need to hold up this...

Adding documentation to functions

Hi @Mochatr! Though I do agree the build script could use more inline documentation, I'm curious what your intended use case for these functions are? That may help us frame...

Adding documentation to functions

I'm closing this issue due to inactivity. If you believe this is still an issue, please feel free to re-open. Thanks!

CesiumJS should not use `push.apply` for potentially large arrays

@Tim-Quattrochi Yes, go ahead!