Gabby Getz

Results 774 comments of Gabby Getz

Also reported in https://github.com/CesiumGS/cesium/issues/12649. 1. From https://sandcastle.cesium.com/?src=AEC%20Clipping.html: ![](https://private-user-images.githubusercontent.com/64846155/450826191-ddcf0ff7-3c3b-4f74-a89e-f2e61f15d7fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTMyOTkzMjcsIm5iZiI6MTc1MzI5OTAyNywicGF0aCI6Ii82NDg0NjE1NS80NTA4MjYxOTEtZGRjZjBmZjctM2MzYi00Zjc0LWE4OWUtZjJlNjFmMTVkN2ZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzIzVDE5MzAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2N2MzOTUwN2JkNWEwNzQ2NTI4MmY3M2YwODE2ZWJhZGQ5ZTBmZDFmZWE5ODFhNDdlN2IyMTMzODdlZTRmMjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AjXdGomAD97XWGfC3sMcZNofFdDQMm3snt8x0YeiXew) 2.

Thanks for the report @eclosion! I believe this is a regression from https://github.com/CesiumGS/cesium/pull/12100.

I agree. We should either have a better error message, or just ignore `baseLayer` and other irrelevant options entirely.

Yes, I think a `DeveloperError` would be appropriate. @nitesh2920 would you be interested in opening a PR?

I like the idea of isolating the average FPS logic in one place. The update itself should probably still happen in `Scene.js` though, (as @lukemckinstry [just implemented](https://github.com/CesiumGS/cesium/pull/12211/commits/b5ac693ebf3f477e53ffdfcf4f38b8aa38a163a9)).

Please excuse the comments on outdated code, I'm not sure how they snuck in there.

@lukemckinstry I'm going to close this to keep things tidy. If you or anyone else wants to update and finish this out, please feel free to re-open!

Hi @ZhuJun-WHU, we do have some existing [imagery adjustment options](https://sandcastle.cesium.com/?src=Imagery%20Adjustment.html). There's nothing for inverting the color, but are you able to achieve similar results to "FilterColter" by adjusting the `hue`...

@tigerchase96 As a workaround, similar to what @s3xysteak brought up, you can set `targetFrameRate` to `60` to throttle the frame rate on devices with a higher refresh rate. That being...

I think it's valid to have this issue open: 1. We no longer support IE 11 2. This would be a discrete step towards [full TypeScript](https://github.com/CesiumGS/cesium/issues/4434) We will need to...