Gabby Getz

Results 774 comments of Gabby Getz

@jjspace Could you please review? Additionally, @angrycat9000 can you take a look from a usability standpoint?

> Hi Gabby, thanks for working on this. I wasn't able to run the sandcastle. @angrycat9000 Apologies, I forgot to push up my last commit. Everything should be good to...

@angrycat9000 Since you instantiated the earth options (terrain provider and imagery provider) while the default ellipsoid was set to the Moon, they were created with the Moon's ellipsoid. You can...

@angrycat9000 Gotcha. In the meantime I'll look into seeing if we have better ways of transitioning between the two.

@angrycat9000 This was turned off by default since the star positions are not accurate when using the moon as the central body. It can be re-enabled.

> Not that it has to be in this PR, but curious about what would be the level of effort to get an accurate skybox suitable for use with lunar...

> Might also be a nice change to set the globe base color to a grey instead of blue when using the moon ellipsoid. For now, I think it's best...

@jjspace This should be ready for another look.

@javagl If the follow up is all documented in #12225, I'm happy to close this in favor of that issue.