Geoff Macartney

Results 22 comments of Geoff Macartney
trafficstars

hi @iyovcheva just checking over brooklyn-server open PRs, what's the latest on this one? Do you want to update it as @neykov mentioned [above](https://github.com/apache/brooklyn-server/pull/690#discussion_r118445857)?

@grkvlt there should be some unit tests at least along with these, can you add some?

Thanks very much for the feedback @tsaarni 🙇 we'll have a look at this and try to get back with updates as soon as possible.

Many thanks for taking the time to provide the lint fixes. We'll update the docs and add the changelog as soon as possible.

Hello @tsaarni I have made the changes to the documentation you mentioned. The first commit 934ca48 is a pure format change to tidy the table borders; the diff therefore looks...

Hi @davinci26 @tsaarni I have updated the branch according to your comment above, so that it is now possible to request different types of compression, including none. Rather than a...

Could you kindly review and enable the build workflows on this to see if they all pass? In the branch where it was built I was getting an odd error...

Have added one more fix of a test, but I still need to finish testing on-cluster, will update the ticket when I get that completed.

Hello @davinci26 @tsaarni, I have updated the code per the proposal to support better API extensibility by wrapping the settings in a struct. I believe this PR is ready for...

Hello @tsaarni, @davinci26, would you be able to review this? Thanks.