brooklyn-server icon indicating copy to clipboard operation
brooklyn-server copied to clipboard

Add series of meta effectors for composite operations

Open grkvlt opened this issue 7 years ago • 4 comments

Adds ComposeEffector, SequenceEffector, TransformEffector and LoopEffector for orchestrating effector calls in blueprints.

Also ScheduledEffectorPolicy and PeriodicEffectorPolicy policies to execute an effector at a scheduled time or periodically.

TODO Add tests for each new effector type and basic documentation

grkvlt avatar Mar 22 '17 16:03 grkvlt

@grkvlt there should be some unit tests at least along with these, can you add some?

geomacy avatar Mar 23 '17 16:03 geomacy

@grkvlt this PR is rather large, and missing tests. I suggest it is closed for now and we work out a way to break this down.

Some ideas for how to break it down: *) Separate PR's per effector would be nice *) New sensor types as separate PRs (e.g. AbstractCompositeEffector/PeriodicEffectorPolicy.java) *) Refactors as separate PRs (Moving AddSensor)

This should make it easier to review and merge.

What are your thoughts on this?

Graeme-Miller avatar May 05 '17 12:05 Graeme-Miller

@Graeme-Miller I think once the tests are added it should be OK, as the individual effectors are all reliant on a single parent abstract class, so they fit together. I will work with @robertgmoss on getting this done and reviewed.

grkvlt avatar May 05 '17 15:05 grkvlt

@grkvlt Unfortunately it looks like this branch has gone stale since you updated it. Can you have a look to see if it is still relevant (I suspect it is), and rebase against master

Thanks

nakomis avatar Nov 26 '19 11:11 nakomis