Geoffrey Biggs comments

Results 149 comments of


                                            Geoffrey Biggs

Import setuptools before distutils

Can you please supply a list of commands to run and the necessary environment to verify this change works?

Build failed foxy+melodic:Failed to find ROS 2 package 'diagnostic_msgs'

Are you using Foxy and Melodic on Ubuntu 18.04? I think it's worth noting that Foxy is not supported on 18.04 so errors are not surprising.

Added functions Nodelet::ok() and Nodelet::requestStop()

@peci1 Is it possible to create an automated test to verify the correct functionality?

Added functions Nodelet::ok() and Nodelet::requestStop()

Have you solved that problem?

TF Latency

The bridge will introduce some delay because it has to receive the data, translate it into a different data type, then broadcast it again. The length of this delay will...

sensor_msgs/Range lacks variance field

Yes, if a PR were provided I think we would consider it.

feat: enable plugin blacklist

Please change this to use a whitelist rather than a blacklist, with an additional option to enable all publishers.

Republishing multiple cameras has unexpected results

Reading through the issue, I think I need some bag files so I can debug what's going wrong. - I don't think I can reproduce problem 1 without a bag...

Republishing multiple cameras has unexpected results

I think you might be providing the parameters to the `image_transport` command incorrectly. My reading of the documentation and source is that you need to run one instance per camera...

Add another constructor for image_transport

This PR isn't inherently bad, but we think a better approach can be taken: rather than receiving a `Node*` or `Node::SharedPtr`, it would be better to receive a template type...