Gavin King comments

Results 1136 comments of


                                            Gavin King

Clean up classes and interfaces for native queries

I don't understand what you're saying here. `ReactiveNativeQueryImplementor` is an SPI interface. It should *never* be returned by any APIs. (And it isn't, AFAIK.)

Clean up classes and interfaces for native queries

Things with `Reactive` in the name are SPI/implementation. We don't expose them to the application program. I'm not sure why we have `ReactiveNativeQuery` and friends. They are probably not be...

Clean up classes and interfaces for native queries

So @DavideD if you wanted to add `Stage.NativeQuery` and `Mutiny.NativeQuery` to our API, then in principle you _could_. But I would very much recommend against that because it would just...

Clean up classes and interfaces for native queries

The usual way to do it since JPA 1.0 is to use a `@SqlResultSetMapping`, not this old stuff.

Clean up classes and interfaces for native queries

Note that I just opened https://github.com/jakartaee/persistence/pull/691 to finally have a JPA-standard way to define result set mappings programmatically. Will have to wait for JPA4 though.

Expose Metamodel getters in the SessionFactory APIS

Not sure what this issue is about, but if it's about exposing `org.hibernate.metamodel.MappingMetamodel` on an API, we should definitely not do that. `MappingMetamodel` exposes SPI-level types. Notice that `SessionFactory` in...

Expose Metamodel getters in the SessionFactory APIS

Note that it's already exposed via `ReactiveSession.getFactory().getMappingMetamodel()`. (Which is an SPI.)

Question mark not escaped in a query (using PostgreSQL JSON data)

I just tried it in Hibernate ORM 7, and `\\?\\?` appears to work as expected.

HHH-14711 unsigned types causing out of range on MySQL/MariaDB

Actually, @peter1123581321, is this a breaking change to existing native SQL queries which are expecting the narrower types?

HHH-14711 unsigned types causing out of range on MySQL/MariaDB

@peter1123581321 see my comment here: https://hibernate.atlassian.net/browse/HHH-14711?focusedCommentId=122112