Gavin King comments

Results 1136 comments of


                                            Gavin King

HHH 18705 - Hibernate processor creates bad TypedReferenceQuery when @Entity have name attribute

@cigaly Looks like there's a compilation failure.

HHH 18705 - Hibernate processor creates bad TypedReferenceQuery when @Entity have name attribute

Thanks @cigaly

@MapKey(name=...) inconsistent with @OrderBy(....)

In a way it should really be `@MapKey(mappedBy= .... )`. That would make the true semantics much clearer.

HHH-18837 Oracle epoch extraction doesn't work with dates

I don't understand what's going on here. HQL doesn't have a documented `epoch()` function. - is this a new feature? If so it needs to be added to the documentation....

HHH-18678 Use specific check tasks for CI build

Neither does checkstyle: we have lots of coding conventions which checkstyle has never enforced. If checkstyle didn't measurably slow us down, I wouldn't mind it. But recently I lost almost...

HHH-18678 Use specific check tasks for CI build

If you guys can fix it so that it's not pig slow, and so that the Gradle integration is nonbroken, then by all means, please go ahead and turn it...

HHH-18678 Use specific check tasks for CI build

I am well-aware that this should never have happened. Nevertheless it happened. Because the Gradle integration is broken. Which is precisely why I went and spent another half-day on replacing...

HHH-18678 Use specific check tasks for CI build

Look I agree it would be nice to enforce the brace on a new line rule. But I would also love to be able to enforce the maximum-120-characters per line...

HHH-18678 Use specific check tasks for CI build

> So how else would you suggest we do that? One thing we could do is push an IntelliJ config with the project, so that the IDE automatically applies the...

HHH-18678 Use specific check tasks for CI build

Alternatively, it's probably not terribly difficult to write a spotless step that replaces `^(\s+)} else` with `$1}\n$1else`.