Gavin King

Results 1136 comments of Gavin King

> Like mentioned in the CONTRIBUTING? Well I mean actually including the IntelliJ config in the project itself so it's loaded automatically when you open the project.

> Unfortunately I don't know how to do that. I can set it up if you like. (I used to do it this way on other projects.) The only doubt...

> I can set it up if you like. See #9014 which appears to work.

> I think also there may be a misundertanding here... compilation does not run checkstyle. Does `publishToMavenLocal`? I have to run that quite often when developing `HibernateProcessor`.

The point of using spotless is so that it runs as soon as possible, and so you never get in a situation where you push code that hasn't had spotless...

i.e. the thing that makes checkstyle so awful (apart from the fact that I have to go off and open up its reports in my web browser to find out...

Correct me if I'm wrong, but doesn't this change just take us directly back to exactly the bad place we started from: where I find out about code style violations...

So at one stage a did spend a tiny amount of time thinking about this, the only issue is: 1. Just adding `options` (which was have done in 3.2) wasn't...

> I also wanted to double-check if the `columnList` value is parsed at some point and validated according to the BNF grammar mentioned in the Javadoc? Good point. In our...

No, and what would the semantics of such an operation be? 1. Is it enough to check the second-level cache, or does it have to always go to the database?...