Gavin King
Gavin King
> I think I did not get your point of 2) in your comment on Jira. IMO it makes totally sense to map an unsigned datatype to the next larger...
> Your suggestion is quite good for less code duplication. But there are some potential risks. For example, a contributor modified PostgreSQL related code will influence GaussDB @liubao68 I think...
I doubt it's really correct to assume that an expression which follows a `,` is a parenthesized expression. I mean, what about stuff like: insert into table (col1, col2) values...
Let's avoid stringly-typed `extensionName`s. I think that's what Steve is suggesting.
Naturally,, it broke Envers.
> Why are we dramatically changing the behavior of something we are actively telling people to not use? As I said: > I believe that this is the original root...
As I mentioned on the issue report, there's two ways to fix this problem: 1. the way you've chosen, which is to just use `not`, or 2. alternatively, by replacing...
In the meantime, please: 1. add a test, and 2. squash the commits.
> The "good reason", I suppose, is that it is marginally more optimal to do it in that way. If it's true that it's marginally more optimal, then we should...
@sebersole got time to review this? Apologies for nagging.