George Gastaldi

icon indicating an email [email protected]

icon company @RedHatOfficial icon location Joinville, Santa Catarina, Brasil icon location Principal Software Engineer @RedHatOfficial and @forge Project Lead. @quarkusio core developer. Enjoys submitting PRs to interesting projects

Results 345 comments of George Gastaldi

fix: All user code input should be validated #199

Can we have a test that verifies this is working as proposed? Also it would be nice if you could squash all commits from this PR

Support Compact Constructors in Records

Good idea, want to provide a PR?

Support static blocks in a type declaration

Thanks for the issue. This is a missing feature in Roaster. Want to contribute on a PR?

ROASTER-1: Java Statement Fluent Model

The changes in MethodImpl are not updated to the last commit, could you fix that? Thanks.

ROASTER-1: Java Statement Fluent Model

It looks like it is not using the Forge formatter. Could you apply the formatter and rebase with the latest master? Thanks!

ROASTER-1: Java Statement Fluent Model

This is the formatter used in Eclipse: https://raw.githubusercontent.com/forge/core/master/eclipse-code-formatter-profile.xml

ROASTER-1: Java Statement Fluent Model

I like this, excellent job!

ROASTER-1: Java Statement Fluent Model

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will...

ROASTER-1: Java Statement Fluent Model

@sotty, are you still working on this PR?

ROASTER-1: Java Statement Fluent Model

Awesome, thank you. Haven't fully checked yet, but it would be nice if it supported Lambdas too.