ROASTER-1: Java Statement Fluent Model

[sotty]

Update Copyright

[gastaldi]

The changes in MethodImpl are not updated to the last commit, could you fix that? Thanks.

[sotty]

oops something went wrong with the rebase.. should be fixed now

[gastaldi]

It looks like it is not using the Forge formatter. Could you apply the formatter and rebase with the latest master?

Thanks!

[gastaldi]

This is the formatter used in Eclipse: https://raw.githubusercontent.com/forge/core/master/eclipse-code-formatter-profile.xml

[agoncal]

What about having a method MethodSource<O> setBody( Statement... blocks ); ? This would allow something like :

    method.setBody(
            newDeclare().setVariable(Integer.class, "y"),
            newDeclare().setVariable(String.class, "x")
    );

WDYT ?

[sotty]

Agreed. Actually it's already in the next version of this PR, which I haven't committed yet :)

[agoncal]

Cool. Commit it and I'll give it a try

[sotty]

Next item is checking the consistency of the internal "origin"/"parent" tree

[gastaldi]

I like this, excellent job!

[gastaldi]

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will this be possible?

[sotty]

This is the new feature I (and Mario) started adding in the latest iteration. It needs more testing and some more work, but see the test case here: mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi [email protected] wrote:

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will this be possible?

— Reply to this email directly or view it on GitHub https://github.com/forge/roaster/pull/27#issuecomment-125743320.

[sotty]

Oops broken paste :) https://github.com/sotty/roaster/blob/master/impl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 4:39 PM, Davide Sottara [email protected] wrote:

This is the new feature I (and Mario) started adding in the latest iteration. It needs more testing and some more work, but see the test case here:

mpl/src/test/java/org/jboss/forge/test/roaster/model/statements/ModifyMethodBodyTest.java

On Tue, Jul 28, 2015 at 3:21 PM, George Gastaldi <[email protected]

wrote:

How is parsing of statements work in this proposal? Suppose you want to change some statement in an existing class (change the for loop condition, add another statement), how will this be possible?

— Reply to this email directly or view it on GitHub https://github.com/forge/roaster/pull/27#issuecomment-125743320.

[jamestyrrell]

Any update on this?

[forge-bot]

Can one of the admins verify this patch?

[gastaldi]

@sotty, are you still working on this PR?

[sotty]

I am, and I have just come back to development this week after a long period working on other things. So expect to hear back from me very soon

On Wed, Jul 6, 2016 at 10:16 AM, George Gastaldi [email protected] wrote:

@sotty https://github.com/sotty, are you still working on this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/forge/roaster/pull/27#issuecomment-230804330, or mute the thread https://github.com/notifications/unsubscribe/AAf0Olz4-yQGhfH4n_jwRkNDcGFT18uFks5qS8bDgaJpZM4CfcnO .

[gastaldi]

Awesome, thank you. Haven't fully checked yet, but it would be nice if it supported Lambdas too.

[jamestyrrell]

@sotty That is great to hear as I just started to get my hands dirty and hit a wall when VariableDeclarator.getInit() gives me back a String.

[gastaldi]

Perhaps this project may give some ideas: https://github.com/square/javapoet

[prksean]

@sotty Hi is there any update on this project? Thanks

[kasium]

@sotty I really love this idea. Do you think you are able to finish it in the next time or is there any update on this?

[sotty]

Unfortunately I do not have the bandwidth these days, but I may have time to get back to this project in late around mid May

On Sat, Jan 26, 2019 at 10:07 AM Kai Müller [email protected] wrote:

@sotty https://github.com/sotty I really love this idea. Do you think you are able to finish it in the next time or is there any update on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/forge/roaster/pull/27#issuecomment-457842989, or mute the thread https://github.com/notifications/unsubscribe-auth/AAf0OgSmM5Pj4cpJ6dx29rNeh4WjiJHKks5vHH0ngaJpZM4CfcnO .