George Gastaldi

Results 82 comments of George Gastaldi

That looks cool. Good job! One question: can this extension also be used to create Discord API client apps using the Discord4j library (not a bot specifically, but code that...

> One question: can this extension also be used to create Discord API client apps using the Discord4j library (not a bot specifically, but code that allows compiling the library...

That seems to be specific to the Renarde build and not necessary for other extensions, so I'm +0 for this.

Ah I see. Are we already generating a codestart project next to the extension?

> > Ah I see. Are we already generating a codestart project next to the extension? > > wdym? You said this change is for Quarkiverse extensions with a codestart,...

I can confirm this behavior. > Maybe related to fact that jar is listening on `http://0.0.0.0:8080` and dev on `http://localhost:8080`. That's right, I get the error if I run `mvn...

@Dairdevil is there a reason why these properties are acessed from a static method and not from a `@ConfigItem` as we usually do?

Using a Config class with `@ConfigItem` is better because the build generates an Asciidoc document that can be used in the guides

@Dairdevil you need to add to https://github.com/quarkusio/quarkus/blob/main/extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesConfig.java and use that in your `KubernetesProcessor`

Looks okay to me, but I'll let @iocanel have the final say on this 👍🏻