quarkus icon indicating copy to clipboard operation
quarkus copied to clipboard

Fix Quarkiverse template build and release

Open ia3andy opened this issue 3 years ago • 9 comments

Using only verify in mvn build and release won't let codestart tests pass. Reason is that the tests are using the actual artifacts which should be installed in the local repo with install.

Note: install is the goal just after verify

ia3andy avatar Jul 06 '22 08:07 ia3andy

@FroMage this is the PR to merge if your Renarde release passes.

ia3andy avatar Jul 06 '22 08:07 ia3andy

That seems to be specific to the Renarde build and not necessary for other extensions, so I'm +0 for this.

gastaldi avatar Jul 06 '22 13:07 gastaldi

@gastaldi no this is for all Quarkiverse extensions with a codestart

ia3andy avatar Jul 06 '22 13:07 ia3andy

Ah I see. Are we already generating a codestart project next to the extension?

gastaldi avatar Jul 06 '22 13:07 gastaldi

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

ia3andy avatar Jul 06 '22 14:07 ia3andy

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

You said this change is for Quarkiverse extensions with a codestart, I wonder if quarkus create extension foobar, for example, created a codestart/ module next to the other modules

gastaldi avatar Jul 06 '22 14:07 gastaldi

Ah I see. Are we already generating a codestart project next to the extension?

wdym?

You said this change is for Quarkiverse extensions with a codestart, I wonder if quarkus create extension foobar, for example, created a codestart/ module next to the other modules

Not yet, but we should make this available as an option for sure!

ia3andy avatar Jul 06 '22 14:07 ia3andy

Ok it works: https://github.com/quarkiverse/quarkus-quinoa/actions/runs/2690774954

ia3andy avatar Jul 18 '22 13:07 ia3andy


:waning_crescent_moon: This workflow status is outdated as a new workflow run has been triggered.


Failing Jobs - Building 1889be9ccdaba2085ad65e500e221c965dd9120c

Status Name Step Failures Logs Raw logs
Native Tests - Data2 Build Failures Logs Raw logs

Failures

:gear: Native Tests - Data2 #

- Failing: integration-tests/jpa-oracle 

:package: integration-tests/jpa-oracle

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-integration-test-jpa-oracle: I/O Error

quarkus-bot[bot] avatar Jul 18 '22 15:07 quarkus-bot[bot]

@gsmet I think we should merge this for 2.12.Final, without this, new Quarkiverse extensions with codestarts won't pass CI.

Anyway it will all change, when @gastaldi add JReleaser.

ia3andy avatar Aug 19 '22 07:08 ia3andy