Gary Gregory

Results 851 comments of Gary Gregory

@ppkarwasz Any thoughts?

Hi @ppkarwasz Thank you for the review. I've addressed the relative path issues. I'll look into symbolic links next.

FTR https://issues.apache.org/jira/browse/CONFIGURATION-776

> Any plan to submit this PR? No. Notice that the builds fail. This will have to wait for a major version bump to avoid breaking binary compatibility. You can...

Note: 3.26.0 is the last Java 8-compatible version.

Leaving open as a to-do when we update Java requirements.

As I've pointed out on the dev mailing list: This a horrible mess IMO. To make things even worse, this PR adds public code (the package name is irrelevant), with...

Hello @ekuvardin The build fails, it seems you did not read or follow the steps in https://github.com/apache/commons-collections/blob/master/.github/pull_request_template.md

Hello @XenoAmess -1: I won't spend time reviewing this new code without unit tests. Instead, I'll spend my time writing this: Tests in PRs are important: They show intent, edge...