Gary Gregory

Results 851 comments of Gary Gregory

We do use the release flag if you run the build with an appropriate Java version. I run all my local release candidates with Java 17 for example and rely...

Hello @czpilar Would you please rebase on git master. I'll try to take a look this weekend and see what this means regarding compatibility.

Hello @czpilar The PR doesn't compile on Java 8.

Hello @czpilar Thank you for the updates but it still fails on Java 8. Please build locally before you push. ``` Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:testCompile (default-testCompile) on project...

Hello @czpilar Hm, yeah, I see that now. Let me look consider this over the next couple of days...

Hello @czpilar I'm going to push a release candidate for the current state of git master, and they will clear the decks for this type of change. The component is...

@czpilar OK so it seems this breaks binary compatibility which means a major version change. I'll ponder the consequences...

@workingjubilee Thank you for the link.

The failing test: ```java // abbreviating a shorter string allows maxWidth < 7 assertEquals("...efg", StringUtils.abbreviate("abcdefg", 5, 6)); ``` looks like a bug indeed.