Gary Gregory

Results 858 comments of Gary Gregory

Thank you for your contribution. I am not a fan of the name "NoUnresolvedVariables" because of the two negatives "No" and the "Un" in "Unresolved". Can we come up with...

```@RequiresVariables``` is not quite right either IMO, ```@RequiresResolvedVariables``` might be better.

We should consider if the presence of unresolved variables should: - Log a DEBUG, WARN, ERROR, or FATAL message. - Fail fast or log all unresolved variables. - Fail the...

Looks like Liquibase broke binary compatibility, lovely.

@vy makes a very important point here that I would like to emphasize: if your test passes without the changes to the main tree, then your test does not prove...

Should other modules include this type of change?

https://issues.apache.org/jira/browse/LOG4J2-3319

Hi @atulpendse You will need to rebase this PR to pick up the latest changes.

I would NOT update changes.xml, this makes cherry-picking the commit to master impossible.

Hello @atulpendse In general, you want to avoid breaking binary compatibility, so that means not editing public and protected type names and method signatures. This is critical in the log4j-api...