Gary Gregory
Gary Gregory
Closing: Needs Apache Infra
https://issues.apache.org/jira/browse/VFS-824
How about the http5 file provider?
Hello @destroydestiny Thank for your PR. Please see my scattered comments.
You must have not run a local build with the default Maven goal (`mvn`): ``` [ERROR] src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java:[19,17] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*....
This PR needs a unit test that fails without its main changes. Otherwise, it's just a regression waiting to happen.
Hi @aooohan You'll need a unit test to prove this is a problem because the code appears to provide all the locking needed through synchronized blocks and methods.
Hi @aooohan Thank you for the update. We can wait until you update this PR with a failing test.
Then this PR won't make it because: - You cannot prove anything is wrong - You have not addressed my comment on why the locking already provided through synchronized blocks...
The discussion in https://issues.apache.org/jira/browse/LANG-1603 does not make it clear (to me) if the proposed replacement is convenient enough.